fix: Improved Radau5ODE handling of final time#127
Merged
PeterMeisrimelModelon merged 3 commits intomasterfrom Jan 27, 2026
Merged
fix: Improved Radau5ODE handling of final time#127PeterMeisrimelModelon merged 3 commits intomasterfrom
PeterMeisrimelModelon merged 3 commits intomasterfrom
Conversation
efredriksson-modelon
suggested changes
Jan 27, 2026
Contributor
efredriksson-modelon
left a comment
efredriksson-modelon
left a comment
There was a problem hiding this comment.
Nice work 🍉
Just some minor things with the comment for the code.
efredriksson-modelon
approved these changes
Jan 27, 2026
PeterMeisrimelModelon
added a commit
that referenced
this pull request
Jan 27, 2026
* fix: Improved Radau5ODE handling of final time * chore: refactoring some testing to start using more fixture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first commit is actual fix; 2nd commit is some cleanup/refactoring of tests, lots more that could be done there.