Skip to content

Conversation

@avinashsingh77
Copy link
Contributor

This PR adds the following:

  1. Github workflow for:
    1. Selecting top models based on downloads/trending/likes
      1. Allows filtering based on total size, number of models, model family
      2. Parameters to override model selection criteria
    2. Build modctl
    3. Download models selected in step 1, build them using modctl and push to ghcr.io
  2. Script to select top models, which is used in workflow
  3. README for scripts

Closes #309

Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @avinashsingh77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes an automated pipeline for curating and building popular machine learning models from HuggingFace Hub. By introducing a new GitHub workflow and an accompanying Python script, it ensures that a selection of modctl-compatible models are regularly identified, processed, and made available in ghcr.io, enhancing the accessibility and freshness of pre-built models.

Highlights

  • Automated Model Building Workflow: Introduces a new GitHub workflow to periodically select, build, and publish top HuggingFace models to ghcr.io.
  • Intelligent Model Selection: The workflow incorporates a Python script to filter models based on criteria such as download count, likes, trending status, size limits, and modctl compatibility (e.g., presence of config.json, supported file formats).
  • New Python Script: Adds select-top-models.py to programmatically fetch and filter models from HuggingFace Hub.
  • Comprehensive Documentation: Includes top-model-selection.md to detail the model selection script, its usage, options, and integration with the new GitHub workflow.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build-top-models.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR introduces a useful workflow and script for selecting top models from HuggingFace. The Python script is well-structured and includes good features like command-line arguments and fallback for older library versions. My review includes a few suggestions to improve robustness, performance, and correctness. Specifically, I've pointed out places where exception handling can be improved to aid debugging, suggested some performance optimizations for list lookups, and fixed a typo in the documentation. Overall, this is a great addition.

Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a github workflow to convert top huggingface models

1 participant