Add DstLinkPath into FileMetadata for symlink

[FengyunPan2]

Description

Add DstLinkPath into FileMetadata for symlink

Related Issue

modelpack/modctl#345

[gemini-code-assist]

Summary of Changes

Hello @FengyunPan2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the FileMetadata structure by introducing a dedicated field to capture the destination path of symbolic and hard links. This change is crucial for accurately representing and processing linked files, as it ensures that the target of a link is always available within its associated metadata, improving the robustness and completeness of file system operations.

Highlights

• FileMetadata Enhancement: A new field, DstLinkPath, has been added to the FileMetadata struct. This field is designed to store the destination path for link type files, such as symbolic links (TypeSymlink) and hard links (TypeLink), ensuring that the target of a link is explicitly recorded within the metadata.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a DstLinkPath field to the FileMetadata struct, which is a good addition for handling symbolic links. The implementation is straightforward. My main concern is that the accompanying documentation in docs/annotations.md has not been updated to reflect this change. Since this repository defines a specification, it's critical to keep the documentation synchronized with the code. I've also added one comment to align the code comment with Go's standard documentation practices.

[gemini-code-assist]

According to Go's documentation conventions, comments for exported identifiers should start with the name of the identifier. Please update the comment to start with DstLinkPath instead of dstlinkpath for consistency and to adhere to standard Go style.

Suggested change

	// dstlinkpath is the destination link path for link type files (e.g., TypeLink, TypeSymlink)
	// DstLinkPath is the destination link path for link type files (e.g., TypeLink, TypeSymlink)

[aftersnow]

@FengyunPan2 Thank you for your contribution. Please add "sign-off-by" to solve DCO error, Gemini's comment, and add documentation here: https://github.com/modelpack/model-spec/blob/main/docs/annotations.md#file-metadata-annotation-value

[chlins]

I suggest we should follow the name style of POSIX or golang standard package, Linkname is better is this case. FYI: https://pkg.go.dev/archive/tar

[bergwolf]

Please also update the FileMetadata definition in docs/annotations.md