Skip to content

Conversation

@emilydaemon
Copy link

From what I can tell, this change doesn't break any functionality in the app whatsoever.

@impeeza
Copy link

impeeza commented Mar 10, 2024

I do support this change, is needed in order to build on my setup:
Windows 11
MSYS with packages:

  • devkitPPC r45-1
  • libfat-ogc 1.2.0-1
  • libogc 2.5.0-2 (Seems this is the package with FILL3 instead FILL2)
  • gamecube-tools 1.0.4-1

image

but changing that value the DOL is build correctly.

seems this error was introduced on the latest commit:

e27137d

before that commit the SYS.C file had the correct value.

regards.

@pyorot
Copy link

pyorot commented Dec 9, 2024

i can also vouch for this change; here's the renamed property it fixes

@pyorot
Copy link

pyorot commented Dec 9, 2024

seems this error was introduced on the latest commit:

e27137d

before that commit the SYS.C file had the correct value.

regards.

@impeeza the commit you linked renamed a property to match libogc, which made a breaking change it has since reverted (check my link above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants