fix:Wire resample 16khz into AudioRecorder stop recording#4
Open
Bhup-GitHUB wants to merge 1 commit intomofa-org:mainfrom
Open
fix:Wire resample 16khz into AudioRecorder stop recording#4Bhup-GitHUB wants to merge 1 commit intomofa-org:mainfrom
Bhup-GitHUB wants to merge 1 commit intomofa-org:mainfrom
Conversation
Contributor
Author
|
@BH3GEI can you review it once? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Problem
AudioRecorder::stop_recording()claims to return "16kHz, mono, f32" audiosamples but never actually performs resampling. On Apple Silicon Macs, the
default microphone records at 48kHz. Feeding these raw samples to Whisper
(which expects exactly 16kHz) causes: incorrect transcriptions, garbled
output, or silent failures.
The
resample_to_16khz()function already existed in the same file(lines 92–114) but was never called.
Changes
File:
third_party/mofa-input/src/asr/audio.rssample_rate: u32field toAudioRecorderstructcpalconfig instart_recording()resample_to_16khz()instop_recording()before returning samplesifblock andTODOcomment