feat(cli): rebased backend command wiring fix for #146#219
Conversation
|
nice work buddy :) , i was about to start fixing the ci tests, and suddenly my pr got merged , so i was not able to fix those issues. |
… fix stale running-agent filter Co-authored-by: Rahul-2k4 <216878448+Rahul-2k4@users.noreply.github.com>
|
@mugiwaraluffy56 yeah had a lot of things to work upon , np but atleast u should have informed @lijingrs abt this , i had again lots of doubts wt happened and how was it merged 😆 . |
|
yep @Rahul-2k4 i wont repeat these mistakes next time. |
97ef682 to
a4931f0
Compare
|
@lijingrs ill ping u when i have reviewed it once more , until then pls dont merge as this is a big implementation that is why it is hard to review |
Got it added to the review list |
|
hi @lijingrs i have reviewed this myself as well as also double checked with copilot .it is all good to go . |
Thanks for your contribution. Could you implement practical example code under the examples directory, from a user's perspective, to verify whether all CLI commands are production-ready? |
|
You've implemented many features. Could you also update the README at the same time? Thanks! |
|
ok sure @lijingrs ill look into this thing and will ping u after awhile |
|
some questions :
|
|
|
i think ill include the focused section for this |
Perfect Go ahead! |
|
ok @lijingrs u can merge this , ill shortly open a pr for the other requirement which are essential and wt u asked for . thank u 😉 🚀 |
📋 Summary
This PR reintroduces and finalizes the backend CLI command wiring for agent/plugin/session/tool flows after regressions from #148.
It restores the complete #146 behavior set from PR #154, rebased cleanly onto latest
main, with equivalent code content and a conflict-free history.🔗 Related Issues
Closes #146
Related to #148, #154
🧠 Context
PR #148 introduced build/runtime regressions and did not fully implement the intended command backend behavior.
PR #154 already had end-to-end implementation for the required command flows, but maintainers requested a latest-main conflict resolution and resubmission.
This branch (
feature/cli-backend-connections-146-rebased) is a clean rebased replacement preserving the same functional scope as #154 while aligning with currentmain.🛠️ Changes
mofa-clicommand surface (agent/plugin/session/tool) throughCliContext, registries, and persistent stores.agent start --type)🧪 How you Tested
origin/mainand verified clean replay of all feature commits viagit range-diff.git diff(no file-content drift between old/new feature branches).cargo test -p mofa-cli -p mofa-foundationmofa-cli: 37 tests,mofa-foundation: 201 tests, doctests completed)##Logs
CLI verification summary:
mofa-cli: 37 passed, 0 failedmofa-foundation: 201 passed, 0 failedIf breaking:
🧹 Checklist
Code Quality
cargo fmtruncargo clippypasses without warningsTesting
cargo testpasses locally without any errorDocumentation
PR Hygiene
main🧩 Additional Notes for Reviewers