Add minimal bash support #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bash users should add to their .bashrc: source path/to/dir/cd-bookmark/cd-bookmark Reference for completion implementation: https://opensource.com/article/18/3/creating-bash-completion-script Fixes mollifier#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for bash, that works along-side (an unaffecting) the zsh support. Completion for bash is added as well, including relative path completion (
$ cd-bookmark -c BOOKMARKID/path<tab>)!This patch was tested on zsh
5.8and bash5.1.8on macOS and it works with both shells.This is a minimal support patch. I can understand if you don't want to merge this PR as-is, as maybe you would like to structure it differently. In that case, let's use this PR as a start of the conversation.
Otherwise, this PR does add working bash support without compromising zsh support. I've encountered no issues so far.