Fix some linter warnings, part 21#297
Closed
digitalfishpond wants to merge 3 commits intomonasca:masterfrom
Closed
Fix some linter warnings, part 21#297digitalfishpond wants to merge 3 commits intomonasca:masterfrom
digitalfishpond wants to merge 3 commits intomonasca:masterfrom
Conversation
digitalfishpond
added a commit
to digitalfishpond/monasca-docker
that referenced
this pull request
Oct 25, 2017
Contributor
Author
|
@timothyb89 the changes in this PR are not what is causing Travis to fail (as proved by #298). Unfortunately, this PR is the only thing standing in the way of #263 being merge-able. Do you have any suggestions? |
Member
|
Fixed in #302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes some errors for #263 (formerly #191)
!push monasca-thresh