Change default value of DELEGATE_AUTHORIZED_ROLES#346
Open
haruki-yamanashi wants to merge 2 commits intomonasca:masterfrom
Open
Change default value of DELEGATE_AUTHORIZED_ROLES#346haruki-yamanashi wants to merge 2 commits intomonasca:masterfrom
haruki-yamanashi wants to merge 2 commits intomonasca:masterfrom
Conversation
Contributor
Author
be9d6d0 to
88c254b
Compare
Contributor
|
https://github.com/openstack/monasca-agent/blob/master/docs/MonascaMetrics.md#cross-tenant-metric-submission |
Member
|
Don't you also need to change it in Keystone? |
Member
|
@matrixik But only in OpenStack's Keystone. The only scenario when delegate roles are used, is libvirt monitoring. |
Member
|
Every time same tempest test fail:
|
Change default value of DELEGATE_AUTHORIZED_ROLES from `admin` to `monitoring-delegate` because of following two reasons. - There is inconsistency between monasca-docker default value and OpenStack monasca agent project document. - It's not secure to allow admin authorization to other users.
63a109c to
16db182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change default value of DELEGATE_AUTHORIZED_ROLES from
admintomonitoring-delegatebecause of following two reasons.OpenStack monasca api project document.