So far use STORM_UI_HOST isn't suitable for docker, because container…#519
Open
like-inspur wants to merge 2 commits intomonasca:masterfrom
Open
So far use STORM_UI_HOST isn't suitable for docker, because container…#519like-inspur wants to merge 2 commits intomonasca:masterfrom
like-inspur wants to merge 2 commits intomonasca:masterfrom
Conversation
… ip will be changed. So it should expose address using 0.0.0.0
matrixik
requested changes
Aug 28, 2019
Member
matrixik
left a comment
matrixik
left a comment
There was a problem hiding this comment.
Please, bump version in https://github.com/monasca/monasca-docker/blob/master/storm/build.yml#L3
from 1.1.1-1.0.12 to 1.1.1-1.0.13
| nimbus.childopts: "{{ NIMBUS_CHILDOPTS }}" | ||
|
|
||
| ui.host: "{{ STORM_UI_HOST | default ('127.0.0.1') }}" | ||
| ui.host: 0.0.0.0 |
Member
There was a problem hiding this comment.
I would prefer to allow operator to change ui.host if he want to, so instead of removing all configuration option just replace default value: "{{ STORM_UI_HOST | default ('0.0.0.0') }}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… ip will be changed. So it should expose address using 0.0.0.0