-
Notifications
You must be signed in to change notification settings - Fork 50
Added mcp support tool #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| // Build the event data | ||
| const eventData: Record<string, unknown> = { | ||
| feedbackType: input.type, | ||
| message: input.message, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice I did not add a toolType and toolName as I don't think it is needed (we do have those in our track tool event)
| // Return success message | ||
| const feedbackTypeLabel = input.type.replace('_', ' '); | ||
| return { | ||
| content: `Thank you for your ${feedbackTypeLabel}! Your message has been sent to the monday MCP team. We review all feedback to improve the toolkit and will use this to make the MCP better.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should speak in first person like this - will be confusing as to who this message is coming from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I fully understand your comment.
I changed the text to:
Thank you for your ${feedbackTypeLabel}! Your message has been sent to the monday MCP team. The team reviews all feedback to improve the toolkit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh got it.
Changed it to:
Message has been sent to the monday MCP team. The team reviews all feedback to improve the toolkit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about it online:
Changed the message to:
Message has been sent successfully. Thank you for your feedback!
packages/agent-toolkit/src/core/tools/platform-api-tools/send-mcp-support-tool.ts
Outdated
Show resolved
Hide resolved
packages/agent-toolkit/src/core/tools/platform-api-tools/send-mcp-support-tool.ts
Outdated
Show resolved
Hide resolved
| - User errors like invalid input or missing required parameters | ||
| - Expected validation errors or permission issues | ||
| The MCP team reviews all submissions to improve the toolkit.`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The MCP team reviews all submissions to improve the toolkit.`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…e concised and clear
IMPORTANT
THIS PR CAN NOT BE MERGED UNTIL WE WILL HAVE A PII TABLE IN BIG BRAIN
With this tool clients can send us bug reports/feature requests/feedback/other things. And we can track it on big brain.
Here is a good example for its usage:
On big brain:
