Skip to content

Conversation

@Anemy
Copy link
Member

@Anemy Anemy commented Jan 9, 2026

Should fix draft release not recognizing .ts

https://nodejs.org/en/learn/typescript/run-natively

If you are using v22.18.0 or later and your source code contains only erasable TypeScript syntax, you can execute TypeScript code without any flags.

@Anemy Anemy requested a review from a team as a code owner January 9, 2026 20:49
Copilot AI review requested due to automatic review settings January 9, 2026 20:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Node.js version requirements across the project to address an issue with draft releases not recognizing TypeScript files. The changes standardize on Node.js v22.21.1 and remove support for Node.js v20.x.

Changes:

  • Removed Node.js v20.x support and updated minimum v22 version to 22.20.0 in package.json
  • Updated Node.js version to 22.21.1 across all GitHub Actions workflows

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updated engine requirements to require Node.js 22.20.0+ or 23.0.0+
.github/workflows/test-and-build.yaml Updated fallback Node.js version from 22.20.0 to 22.21.1
.github/workflows/test-and-build-from-fork.yaml Updated fallback Node.js version from 22.20.0 to 22.21.1
.github/workflows/publish-release.yaml Updated Node.js version from 22.15.1 to 22.21.1
.github/workflows/draft-release.yaml Updated Node.js version from 22.15.1 to 22.21.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Anemy Anemy added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jan 9, 2026
"engines": {
"vscode": "^1.101.1",
"node": "^20.19.0 || ^22.12.0 || >= 23.0.0",
"node": "^22.20.0 || >= 23.0.0",
Copy link
Contributor

@himanshusinghs himanshusinghs Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my memory serves right, the original change was a requirement coming out of one of the transitive dependency working strictly with the earlier mentioned values. With the updated value we're missing the guard against version below 20.19.0.

Alternative is to keep the old and update the v22 to the suggested version here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants