MONGOID-5842 fix numericality validator when given non-numeric strings #6108
+162
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Mongoid's typecasting functionality differs from that of Rails, the numericality validator was incorrectly accepting non-numeric strings if `allow_blank: true` was specified.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug (MONGOID-5842) where the numericality validator was incorrectly accepting non-numeric strings when allow_blank: true was specified. The root cause is that Mongoid's numeric typecasting behavior differs from ActiveRecord - when a non-numeric string like "asdf" is assigned to a numeric field (Integer, Float, BigDecimal), Mongoid's type casting returns nil rather than keeping the invalid string value. This made the validator incorrectly treat these invalid strings as blank values.
Changes:
- Reimplements
EachValidator#validateinNumericalityValidatorto check the raw value before type casting - Adds
raw_value_for_validationmethod to retrieve the attribute value before Mongoid's type casting occurs - Adds comprehensive test coverage for the fix across Integer, Float, and BigDecimal field types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lib/mongoid/validatable/numericality.rb | Overrides the validate method to check raw values before type casting, ensuring non-numeric strings are properly validated even with allow_blank: true. Adds helper method to retrieve raw attribute values. |
| spec/mongoid/validatable/numericality_spec.rb | Restructures and expands test coverage to verify the fix works correctly for Integer, Float, and BigDecimal fields with both allow_blank: false and allow_blank: true options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
comandeo-mongo
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Mongoid's numeric typecasting functionality differs from that of ActiveRecord, the numericality validator was incorrectly accepting non-numeric strings if
allow_blank: truewas specified. This PR copies and reimplements Rails'EachValidator#validatemethod, correctly accounting for this difference between Mongoid and ActiveRecord.