Skip to content

Conversation

@gabrieltmonkai
Copy link
Contributor

@gabrieltmonkai gabrieltmonkai commented Jan 23, 2026

Overview

Jira Ticket Reference : MN-821

Migrate Demo-App from using create-react-app to ViteJS

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have updated the local app configs if needed
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

@apiiro
Copy link

apiiro bot commented Jan 23, 2026

Workflows: "WORKFLOW-22 · Monk - Slack Alert and PR Comment - Vulnerable Dependency Found - Critical"
Policies: "SCA OSS Vulnerabilities - Critical Severity"

⚠️ Apiiro found 1 new risk - 1 critical ⚠️

Risks identified in /apps/demo-app-vite/package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 3.1.10
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%

Repository: monkjs

View in Apiiro

@apiiro
Copy link

apiiro bot commented Jan 23, 2026

Workflows: "WORKFLOW-22 · Monk - Slack Alert and PR Comment - Vulnerable Dependency Found - Critical"
Policies: "SCA OSS Vulnerabilities - Critical Severity"

⚠️ Apiiro found 4 new risks - 4 critical ⚠️

Risks identified in /apps/demo-app/package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 4.0.1
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%
Risks identified in /apps/demo-app-vite/package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 4.0.1
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%
Risks identified in /apps/demo-app-video/package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 4.0.1
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%
Risks identified in /package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 4.0.1
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, Dev dependency, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%

⚠️ Apiiro found 3 resolved risks - 3 critical ⚠️

Risks identified in /apps/demo-app-video/package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 3.1.10
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%
Risks identified in /apps/demo-app/package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 3.1.10
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%
Risks identified in /package.json - 🟤 1 critical Total detected risks 1, Displayed (deduplicated, showing only the highest severity per package): 1
🟤 1 critical - ejs · max CVSS 9.8
  • SCA OSS Vulnerabilities - Critical Severity in dependency ejs
  • Dependency: ejs : 3.1.10
  • Type: Sub-dependency
  • Insights: Not fixable, Adequately tested, Popularity, Single maintainer, Has vulnerabilities, Dev dependency, High EPSS, Public repository
  • Max CVSS Score: 9.8
  • Total Vulnerabilities 1(1 Critical):
ID Vulnerability CVSS Exploit maturity EPSS Fix version
CVE-2023-29827 Server-Side Template Injection in ejs v3.1.9 9.8 No exploit maturity data Score: 0.80822
Percentile 99.11%

Repository: monkjs

View in Apiiro

"@monkvision/camera-web",
"@monkvision/common-ui-web",
"@monkvision/inspection-capture-web",
"@monkvision/inspection-review",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 'm getting an error with inspection-review since it is not in the main branch yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! It remained following my tests with that package.
Did you get other errors after you remove that line?

@dlymonkai
Copy link
Contributor

You have created a new app demo-app-vite, actually we want to replace CRA in demo-app and demo-video-app

@gabrieltmonkai
Copy link
Contributor Author

You have created a new app demo-app-vite, actually we want to replace CRA in demo-app and demo-video-app

That's as intended for now, to be easier for us to review both apps and assure the -vite one works 1:1 with the original one.

@gabrieltmonkai gabrieltmonkai force-pushed the feat/MN-821/migrate-to-vite branch from 8ea4aa5 to dd3adbf Compare January 28, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants