Conversation
| end if | ||
| end repeat | ||
| return(mergJSONEncode("pArray",pForceRootType,pPretty)) | ||
| if pArray is not empty then |
Owner
There was a problem hiding this comment.
@mwieder I'm fairly sure this is wrong and should be if pArray is an array then
| end repeat | ||
| return(mergJSONEncode("pArray",pForceRootType,pPretty)) | ||
| else | ||
| return empty |
Owner
There was a problem hiding this comment.
Hmm... empty is invalid JSON..... so I'm not convinced this is a good idea
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If JSONToArray is passed an empty parameter for the JSON object, the external fails to parse it and returns an error message. That ends up hanging the calling function and it isn't possible to edit the calling script because the engine is in a "script is still executing" state. The only way out is to force-quit LC and lose and unsaved changes. This PR just returns empty if the JSON parameter is empty and so avoids getting into the force-quit situation.