Improve recursive render robustness (hidden files, casing, error handling)#121
Open
036006 wants to merge 8 commits intomorevnaproject-org:masterfrom
Open
Improve recursive render robustness (hidden files, casing, error handling)#121036006 wants to merge 8 commits intomorevnaproject-org:masterfrom
036006 wants to merge 8 commits intomorevnaproject-org:masterfrom
Conversation
…mlinks, and render directories
morevnaproject
requested changes
Jan 20, 2026
renderchan/cli.py
Outdated
| if _is_hidden(file, f): | ||
| continue | ||
| # Skip symlinks | ||
| if os.path.islink(file): |
Collaborator
There was a problem hiding this comment.
I think we shouldn't skip symlinks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden recursive render traversal: validate directory input, skip symlinks/hidden/system entries and render subtrees, and make extension filtering case-insensitive.
Add resilience: handle os.listdir failures with warnings, log relpath cross-drive issues on Windows instead of crashing, and improve hidden detection for Windows attributes.
Keep the cache open during local recursive renders to avoid closed-DB errors.