Fix: Do not require t.Parallel if the function uses t.Setenv#31
Open
SimoTod wants to merge 3 commits intomoricho:masterfrom
Open
Fix: Do not require t.Parallel if the function uses t.Setenv#31SimoTod wants to merge 3 commits intomoricho:masterfrom
SimoTod wants to merge 3 commits intomoricho:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the linter so it does not report an error when
t.SetEnvis used.For example
TestSomething cannot be run in parallel as it sets an env variable. However, once or more children could still be allowed to run in parallel. When combined to other linters like
paralleltest, this conflicts and forces developers to addnolintcomments to their tests.Fixes #25