-
Notifications
You must be signed in to change notification settings - Fork 58
Add details on Bridge section #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- added details on Deposit from ETH to Morph section
WalkthroughThis pull request updates the bridge documentation file with detailed step-by-step instructions for the Morph Bridge deposit process. It replaces legacy reference links with expanded in-page guides, corrects Hoodi-related network labels, and refines wording for clarity across mainnet and testnet sections. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/quick-start/4-bridge.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/quick-start/4-bridge.md
12-12: Bare URL used
(MD034, no-bare-urls)
27-27: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (3)
docs/quick-start/4-bridge.md (3)
10-21: Clear, step-by-step deposit instructions for mainnet.The new Instructions subsection provides a comprehensive, user-friendly guide for depositing from Ethereum to Morph. The steps are logically ordered, specific about wallet interactions, and include helpful guidance on tab switching and transaction verification.
23-30: Accurate Hoodi network label correction.The update from "Morph L2" to "Morph Hoodi" correctly reflects the Hoodi testnet destination. This aligns terminology across the instructions and reduces user confusion.
34-36: Helpful clarification on ERC20 token approval.The added tip block clearly explains the first-time ERC20 approval step, which is a common point of friction for users unfamiliar with the approval flow. This improves the user experience.
| ### Instructions: | ||
|
|
||
| 1. Go to the Morph Bridge: https://bridge.morphl2.io | ||
| 2. Open MetaMask and switch to the **Ethereum** network. | ||
| 3. In the Morph Bridge app, click **Connect Wallet**, select MetaMask, and approve the connection. | ||
| 4. Ensure **Ethereum** is selected under “From” and **Morph** under “To”. If not, click the “Deposit” tab or click the ↓ button found on the top right to switch them. | ||
| 5. Select the token you want to transfer. | ||
| 6. Click **Send** to start the deposit. | ||
| 7. A confirmation window will appear. Click **Deposit**. | ||
| 8. In MetaMask, click **Confirm**. Once the transaction finalizes, the token will be deducted from your Ethereum wallet. | ||
| 9. To check the status, click the **Transactions** button in the bridge app. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap bare URLs in angle brackets per Markdown linting standards.
Lines 12 and 27 contain bare URLs that violate the MD034 rule. Wrap them in angle brackets to follow Markdown best practices and improve parseability.
Apply this diff to wrap the bare URLs:
-1. Go to the Morph Bridge: https://bridge.morphl2.io
+1. Go to the Morph Bridge: <https://bridge.morphl2.io>Similarly for line 27:
-1. Go to the Morph Hoodi Bridge: https://bridge-hoodi.morphl2.io
+1. Go to the Morph Hoodi Bridge: <https://bridge-hoodi.morphl2.io>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### Instructions: | |
| 1. Go to the Morph Bridge: https://bridge.morphl2.io | |
| 2. Open MetaMask and switch to the **Ethereum** network. | |
| 3. In the Morph Bridge app, click **Connect Wallet**, select MetaMask, and approve the connection. | |
| 4. Ensure **Ethereum** is selected under “From” and **Morph** under “To”. If not, click the “Deposit” tab or click the ↓ button found on the top right to switch them. | |
| 5. Select the token you want to transfer. | |
| 6. Click **Send** to start the deposit. | |
| 7. A confirmation window will appear. Click **Deposit**. | |
| 8. In MetaMask, click **Confirm**. Once the transaction finalizes, the token will be deducted from your Ethereum wallet. | |
| 9. To check the status, click the **Transactions** button in the bridge app. | |
| ### Instructions: | |
| 1. Go to the Morph Bridge: <https://bridge.morphl2.io> | |
| 2. Open MetaMask and switch to the **Ethereum** network. | |
| 3. In the Morph Bridge app, click **Connect Wallet**, select MetaMask, and approve the connection. | |
| 4. Ensure **Ethereum** is selected under "From" and **Morph** under "To". If not, click the "Deposit" tab or click the ↓ button found on the top right to switch them. | |
| 5. Select the token you want to transfer. | |
| 6. Click **Send** to start the deposit. | |
| 7. A confirmation window will appear. Click **Deposit**. | |
| 8. In MetaMask, click **Confirm**. Once the transaction finalizes, the token will be deducted from your Ethereum wallet. | |
| 9. To check the status, click the **Transactions** button in the bridge app. |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
12-12: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
docs/quick-start/4-bridge.md lines 10-21: the Markdown contains a bare URL
(https://bridge.morphl2.io) that violates MD034; wrap the URL in angle brackets
like <https://bridge.morphl2.io> so it is not a bare link, and scan the
surrounding lines (and line 27 noted in the review) for any other bare URLs and
wrap them similarly to satisfy Markdown linting.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.