This repository was archived by the owner on May 14, 2024. It is now read-only.
Add support for seamless iframes #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an option for supporting seamless iframes. This assumes that the iframe is not scrollable and is meant to look as though it is part of the top window. In this type of iframe, all the elements are always visible. For that reason, we will detect whether elements are visible inside of the top window instead of the iframe.
Added support for seamless iframes
Updated code for supporting seamless iframes to check if the iframe is actually seamless before applying the logic. When the iframe is not seamless, the logic should be the same as when the page is not in an iframe at all. These changes assume that seamless iframes will have scrolling="no" or the HTML5 seamless attribute.
Fix issue with seamless iframe support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve this issue: https://github.com/morr/jquery.appear/issues/58