Skip to content

Conversation

@GOKULRAJ136
Copy link
Contributor

@GOKULRAJ136 GOKULRAJ136 commented Jan 7, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed the download card navigation item from the admin menu, streamlining navigation options and reducing available admin routes.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

Walkthrough

A navigation entry for the download card menu item was removed from the admin UI constants file. The item with route /admin/download-card, audit event ID ADM-009, and DIGITALCARD_ADMIN role requirement has been commented out, reducing the available navigation options in the admin menu.

Changes

Cohort / File(s) Summary
Navigation Configuration
admin-ui/src/app/app.constants.ts
Removed/commented out nav item entry: displayName 'menuItems.item9.title', route '/admin/download-card', auditEventId 'ADM-009', roles ['DIGITALCARD_ADMIN']. Reduces admin menu options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One menu item hops away,
Download card won't see the day,
Constants clean, the list more neat,
Navigation's now complete! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removal of the download card feature from the admin portal navigation, which matches the actual changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @admin-ui/src/app/app.constants.ts:
- Around line 79-86: Remove the partially deleted download-card feature by
deleting the feature module directory named download-card, removing the
lazy-loaded route that references '/admin/download-card' from the
AppRoutingModule (the route that imports the download-card module), and delete
the translation keys "menuItems.item9" and the "download-card" object from all
i18n JSON files; verify no remaining references to the '/admin/download-card'
route or download-card module remain (the DIGITALCARD_ADMIN role can be ignored
as it was only in the commented nav entry).
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 965647b and db07c61.

📒 Files selected for processing (1)
  • admin-ui/src/app/app.constants.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: uitest-admin / build-dockers
  • GitHub Check: build-admin-ui / npm-build
  • GitHub Check: Analyze (java-kotlin)

@ase-101 ase-101 merged commit 0faba15 into mosip:develop Jan 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants