[ES-2395] Java 21 migration sunbird plugin

[Md-Humair-KK]

Summary by CodeRabbit

• Chores
  • Upgraded Java platform from 11 to 21
  • Updated Maven toolchain (compiler, surefire, JaCoCo, javadoc) to newer versions
  • Refreshed core libraries (Lombok, Jackson) for stability and security
  • Improved test setup: added Mockito and updated test-runner configuration

[coderabbitai]

Walkthrough

Project upgraded to Java 21; Maven compiler, surefire, jacoco, javadoc, and several dependency versions updated; Mockito test dependency added; surefire argLine adjusted; PostConstruct and validation imports migrated from javax.* to jakarta.*.

Changes

Cohort / File(s)	Summary
Build & Dependency configuration sunbird-rc-plugin/pom.xml	Java properties and compiler/target bumped 11 → 21. Updated plugin versions: maven-compiler-plugin 2.4 → 3.14.1, maven-surefire-plugin 2.22.0 → 3.1.2. jacoco 0.8.5 → 0.8.14, maven-javadoc-plugin 3.3.1 → 3.4.0. Dependency updates: lombok 1.18.22 → 1.18.42, jackson-databind 2.12.6 → 2.15.0, esignet and kernel-keymanager-service versions bumped, and org.mockito:mockito-core:5.20.0 added (test). Removed --illegal-access=permit from surefire argLine.
Jakarta import migration sunbird-rc-plugin/src/main/java/io/mosip/esignet/plugin/sunbirdrc/service/SunbirdRCAuthenticationService.java	Switched annotation imports from javax.* to jakarta.* (e.g., PostConstruct, validation annotations); no logic changes.

Sequence Diagram(s)

(The changes are configuration and import-only; no control-flow or runtime interaction changes to diagram.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Review compatibility of updated libraries (Jackson, Lombok, plugins) with Java 21.
• Confirm tests run under updated surefire config and removal of --illegal-access=permit causes no CI failures.
• Validate no additional javax→jakarta migration gaps elsewhere.

Poem

🐰 I hopped from eleven to twenty-one, so spry,
Dependencies polished, imports waved goodbye.
Mockito joined for tests that play,
Jakarta whispers "hello" today.
A joyful thump — the rabbit's done, hooray! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: upgrading the sunbird-rc-plugin to Java 21, which is the primary focus of the changeset (Java version updates, Maven compiler updates, and related dependency migrations).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e462ce and 666ce94.

📒 Files selected for processing (2)

• sunbird-rc-plugin/pom.xml (5 hunks)
• sunbird-rc-plugin/src/main/java/io/mosip/esignet/plugin/sunbirdrc/service/SunbirdRCAuthenticationService.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• sunbird-rc-plugin/pom.xml

🔇 Additional comments (1)

sunbird-rc-plugin/src/main/java/io/mosip/esignet/plugin/sunbirdrc/service/SunbirdRCAuthenticationService.java (1)

41-44: Jakarta migration for lifecycle and validation imports looks correct

@PostConstruct, @Valid, @NotBlank, and @NotNull are now consistently imported from jakarta.*, matching the Java 21 / Jakarta migration and usage with @Validated on the class. No further changes needed in this segment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

sunbird-rc-plugin/pom.xml (1)

292-292: Resolve maven-surefire-plugin version mismatch.

Line 76 defines the property maven-surefire-plugin.version=3.1.2, but line 292 hardcodes the plugin version to 2.22.0. Update line 292 to use the property variable for consistency.

Apply this diff:

-			<version>2.22.0</version>
+			<version>${maven-surefire-plugin.version}</version>

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a755650 and 0e462ce.

📒 Files selected for processing (2)

• sunbird-rc-plugin/pom.xml (4 hunks)
• sunbird-rc-plugin/src/main/java/io/mosip/esignet/plugin/sunbirdrc/service/SunbirdRCAuthenticationService.java (1 hunks)

🔇 Additional comments (1)

sunbird-rc-plugin/pom.xml (1)

160-165: Good: Test dependency added for improved unit testing.

Adding Mockito 5.20.0 as a test-scoped dependency is a solid choice for mocking external dependencies in unit tests, especially for the service layer with external calls to registry and signature services.