Skip to content

Conversation

@pvsaidurga
Copy link
Contributor

@pvsaidurga pvsaidurga commented Dec 3, 2025

Summary by CodeRabbit

  • Chores
    • Updated project version to 1.4.0-SNAPSHOT across plugins.
    • Updated core dependencies to latest snapshot versions for improved compatibility and access to recent updates.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: pvsaidurga <saidurgacsea@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Walkthrough

Three plugin modules have their project versions bumped from 1.3.5-SNAPSHOT to 1.4.0-SNAPSHOT, and their esignet-related dependencies are updated to 1.8.0-SNAPSHOT and 1.4.0-SNAPSHOT respectively.

Changes

Cohort / File(s) Change Summary
Plugin module version and dependency updates
mock-plugin/pom.xml, mosip-identity-plugin/pom.xml, sunbird-rc-plugin/pom.xml
Project version bumped to 1.4.0-SNAPSHOT; esignet.version updated to 1.8.0-SNAPSHOT; esignet-signup.version updated to 1.4.0-SNAPSHOT (where applicable)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward version bumps across pom files with consistent pattern
  • No logic, functional, or structural changes
  • Purely Maven dependency management updates

Possibly related PRs

Suggested reviewers

  • sacrana0
  • ase-101

Poem

🐰 Hop, hop! New versions bloom,
1.4.0 sweeps the room,
esignet leaps to 1.8 so bright,
Dependencies dance, everything's right!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Updated pom version' is generic and vague, not specifically describing which versions were updated or the scope of the changes across multiple plugin modules. Consider a more descriptive title such as 'Bump plugin versions to 1.4.0 and update esignet dependencies' to clearly indicate the main change and affected modules.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
mosip-identity-plugin/pom.xml (1)

7-8: Minor POM element ordering: version precedes artifactId.

The <version> element is placed on line 7, before <artifactId> on line 8. While this is valid XML and doesn't affect Maven functionality, it deviates from the standard POM convention (groupId → artifactId → version). This formatting is inconsistent with the other two plugin modules (mock-plugin and sunbird-rc-plugin).

For consistency across the project, consider reordering to follow standard conventions.

- <version>1.4.0-SNAPSHOT</version>
- <artifactId>mosip-identity-plugin</artifactId>
+ <artifactId>mosip-identity-plugin</artifactId>
+ <version>1.4.0-SNAPSHOT</version>
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e52adcb and c654a43.

📒 Files selected for processing (3)
  • mock-plugin/pom.xml (2 hunks)
  • mosip-identity-plugin/pom.xml (2 hunks)
  • sunbird-rc-plugin/pom.xml (2 hunks)
🔇 Additional comments (3)
sunbird-rc-plugin/pom.xml (1)

7-7: Version updates align with other plugin modules.

The project and esignet versions are bumped consistently with mock-plugin and mosip-identity-plugin. Note that this module does not include esignet-signup dependency, so the esignet-signup.version property (1.3.1 → 1.4.0) is correctly absent here.

Also applies to: 83-83

mosip-identity-plugin/pom.xml (1)

89-90: Version updates are consistent across all three plugin modules.

The esignet and esignet-signup SNAPSHOT versions align correctly with mock-plugin and sunbird-rc-plugin modules. All dependencies properly reference these properties.

mock-plugin/pom.xml (1)

8-8: Version updates lack verification of SNAPSHOT artifact availability.

While the version property updates (1.3.5 → 1.4.0, esignet 1.7.1 → 1.8.0, esignet-signup 1.3.1 → 1.4.0) are syntactically correct and properly referenced, the corresponding SNAPSHOT artifacts are not available on Maven Central:

  • esignet 1.8.0-SNAPSHOT: Not published to Maven Central; requires either local build from GitHub (mosip/esignet) or configuration of MOSIP/Mulesoft Nexus repository at https://repository.mulesoft.org/nexus/content/repositories/public/
  • esignet-signup 1.4.0-SNAPSHOT: Not found in Maven Central or public repositories; only v1.4.0 release appears to exist

Before merge, confirm that:

  1. The project's pom.xml includes appropriate snapshot repository configuration for MOSIP artifacts, or dependencies are built locally
  2. esignet-signup 1.4.0-SNAPSHOT actually exists in your build environment (may need to use released version 1.4.0 instead)

@pvsaidurga pvsaidurga closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant