-
Notifications
You must be signed in to change notification settings - Fork 21
Updated pom version #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pom version #180
Conversation
Signed-off-by: pvsaidurga <saidurgacsea@gmail.com>
WalkthroughThree plugin modules have their project versions bumped from 1.3.5-SNAPSHOT to 1.4.0-SNAPSHOT, and their esignet-related dependencies are updated to 1.8.0-SNAPSHOT and 1.4.0-SNAPSHOT respectively. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
mosip-identity-plugin/pom.xml (1)
7-8: Minor POM element ordering: version precedes artifactId.The
<version>element is placed on line 7, before<artifactId>on line 8. While this is valid XML and doesn't affect Maven functionality, it deviates from the standard POM convention (groupId → artifactId → version). This formatting is inconsistent with the other two plugin modules (mock-plugin and sunbird-rc-plugin).For consistency across the project, consider reordering to follow standard conventions.
- <version>1.4.0-SNAPSHOT</version> - <artifactId>mosip-identity-plugin</artifactId> + <artifactId>mosip-identity-plugin</artifactId> + <version>1.4.0-SNAPSHOT</version>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
mock-plugin/pom.xml(2 hunks)mosip-identity-plugin/pom.xml(2 hunks)sunbird-rc-plugin/pom.xml(2 hunks)
🔇 Additional comments (3)
sunbird-rc-plugin/pom.xml (1)
7-7: Version updates align with other plugin modules.The project and esignet versions are bumped consistently with mock-plugin and mosip-identity-plugin. Note that this module does not include esignet-signup dependency, so the esignet-signup.version property (1.3.1 → 1.4.0) is correctly absent here.
Also applies to: 83-83
mosip-identity-plugin/pom.xml (1)
89-90: Version updates are consistent across all three plugin modules.The esignet and esignet-signup SNAPSHOT versions align correctly with mock-plugin and sunbird-rc-plugin modules. All dependencies properly reference these properties.
mock-plugin/pom.xml (1)
8-8: Version updates lack verification of SNAPSHOT artifact availability.While the version property updates (1.3.5 → 1.4.0, esignet 1.7.1 → 1.8.0, esignet-signup 1.3.1 → 1.4.0) are syntactically correct and properly referenced, the corresponding SNAPSHOT artifacts are not available on Maven Central:
- esignet 1.8.0-SNAPSHOT: Not published to Maven Central; requires either local build from GitHub (mosip/esignet) or configuration of MOSIP/Mulesoft Nexus repository at
https://repository.mulesoft.org/nexus/content/repositories/public/- esignet-signup 1.4.0-SNAPSHOT: Not found in Maven Central or public repositories; only v1.4.0 release appears to exist
Before merge, confirm that:
- The project's pom.xml includes appropriate snapshot repository configuration for MOSIP artifacts, or dependencies are built locally
- esignet-signup 1.4.0-SNAPSHOT actually exists in your build environment (may need to use released version 1.4.0 instead)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.