-
Notifications
You must be signed in to change notification settings - Fork 153
[MOSIP-44263] Updated workflow references to use as build was failing #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
WalkthroughUpdated GitHub Actions workflow references in Changes
Sequence Diagram(s)(omitted — changes are configuration and a small file download filename adjustment; no new multi-component control flow introduced) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/push-trigger.yml:
- Line 322: Update the reusable workflow reference that currently reads uses:
anup-nehe/kattu/.github/workflows/maven-build-browserStack.yml@develop to a
pinned ref (commit SHA or immutable tag); locate the uses entry in the workflow
file (the line referencing
anup-nehe/kattu/.github/workflows/maven-build-browserStack.yml) and replace the
branch ref (develop) with a specific commit SHA or a signed release tag so the
external reusable workflow cannot drift while high-privilege secrets (OSSRH,
GPG, BrowserStack, Slack) are exposed.
♻️ Duplicate comments (5)
.github/workflows/push-trigger.yml (5)
110-110: Same concern as Line 27: pin mutable workflow refs.Line 110 also uses
@master; please apply the same verification/pinning guidance as noted for Line 27.
124-124: Same concern as Line 27: pin mutable workflow refs.Line 124 also uses
@master; please apply the same verification/pinning guidance as noted for Line 27.
159-159: Same concern as Line 27: pin mutable workflow refs.Line 159 also uses
@master; please apply the same verification/pinning guidance as noted for Line 27.
172-172: Same concern as Line 27: pin mutable workflow refs.Line 172 also uses
@master; please apply the same verification/pinning guidance as noted for Line 27.
195-195: Same concern as Line 27: pin mutable workflow refs.Line 195 also uses
@master; please apply the same verification/pinning guidance as noted for Line 27.
🧹 Nitpick comments (1)
.github/workflows/push-trigger.yml (1)
27-27: Pin the reusable workflow ref and confirm Java toolchain expectations.Line 27 switches to
@master, which is mutable and may change the Java/toolchain behavior unexpectedly. Please verify themasterworkflow still matches the required Java version and consider pinning to a tag or commit SHA for reproducibility and supply-chain hardening.🔒️ Suggested pinning (example)
- uses: mosip/kattu/.github/workflows/maven-build.yml@master + uses: mosip/kattu/.github/workflows/maven-build.yml@<tag-or-commit-sha>
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/push-trigger.yml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-19T07:14:21.109Z
Learnt from: mohanachandran-s
Repo: mosip/esignet PR: 1590
File: api-test/pom.xml:76-85
Timestamp: 2025-12-19T07:14:21.109Z
Learning: In the mosip/esignet repository, the distributionManagement release repository uses `https://central.sonatype.com/api/v1/publisher` with the central-publishing-maven-plugin (version 0.7.0), which is the correct configuration for Sonatype Central Portal API-based publishing across all modules.
Applied to files:
.github/workflows/push-trigger.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: oidc-ui / build-dockers
- GitHub Check: build-maven-uitest-esignet / maven-build
- GitHub Check: build_maven_apitest_esignet / maven-build
- GitHub Check: Analyze (java-kotlin)
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.