[MOSIP-44253]Updated validation of rancher import url

[bhumi46]

Summary by CodeRabbit

Release Notes

• Chores
  • Made Rancher import URL optional across all infrastructure modules. The URL now defaults to an empty value and can be safely omitted when Rancher import functionality is not required.
  • Broadened URL validation patterns to accept more flexible domain formats. These infrastructure updates enhance configuration flexibility across different deployment scenarios while maintaining URL format integrity.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The PR updates Rancher import URL configuration across multiple Terraform modules by making the variable optional (allowing empty strings) and generalizing URL validation from hardcoded domain patterns to accept any valid domain format. The tfvars file sets the value to empty.

Changes

Cohort / File(s)	Summary
Configuration File terraform/implementations/aws/observ-infra/aws.tfvars	Set rancher_import_url value from placeholder to empty string
Variable Definition Updates terraform/infra/variables.tf, terraform/modules/aws/variables.tf, terraform/observ-infra/variables.tf	Updated rancher_import_url variable declarations: added default = "", expanded description to indicate value can be empty, modified validation regex to accept empty string or generalized domain-based URL format (replacing hardcoded domain-specific patterns), and updated error messages accordingly

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [MOSIP-43518]All updated changes from develop branch for 2nd patch release #126: Both PRs address Rancher import configuration—this PR broadens validation and adds empty string support for rancher_import_url, while the related PR adjusts the actual tfvars values and implements conditional Rancher import logic.

Suggested reviewers

• ckm007

Poem

🐰 A Rabbit's Rancher Rhyme:
The import URL's now set free,
No hardcoded domains you see,
Empty or dynamic, it flows so nice,
Validation patterns—a softer splice!
Flexibility hops where rigidity was,
Configuration blooms—just 'cause!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating validation logic for the rancher_import_url variable across multiple Terraform configuration files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

🧹 Recent nitpick comments

terraform/modules/aws/variables.tf (1)

46-57: Cross-validation limitation: empty URL passes when import is enabled.

The validation correctly allows empty strings, but Terraform variable validations cannot reference other variables. If ENABLE_RANCHER_IMPORT = true with RANCHER_IMPORT_URL = "", validation passes but the import operation will fail at runtime.

Consider adding a precondition block in the module or resource that consumes these variables to enforce the relationship:

lifecycle {
  precondition {
    condition     = !var.ENABLE_RANCHER_IMPORT || var.RANCHER_IMPORT_URL != ""
    error_message = "RANCHER_IMPORT_URL must be set when ENABLE_RANCHER_IMPORT is true."
  }
}

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6286137 and 65f1ae7.

📒 Files selected for processing (4)

• terraform/implementations/aws/observ-infra/aws.tfvars
• terraform/infra/variables.tf
• terraform/modules/aws/variables.tf
• terraform/observ-infra/variables.tf

🔇 Additional comments (3)

terraform/infra/variables.tf (1)

86-97: Validation is consistent with other modules.

The changes align with the PR objective and maintain consistency across the codebase. The same cross-validation recommendation from the AWS module applies here—consider adding a precondition block where this variable is consumed to ensure rancher_import_url is non-empty when enable_rancher_import is true.

terraform/observ-infra/variables.tf (1)

88-99: LGTM!

The validation changes are consistent with the other modules (terraform/infra/variables.tf and terraform/modules/aws/variables.tf). The same precondition recommendation applies for runtime validation.

terraform/implementations/aws/observ-infra/aws.tfvars (1)

77-79: LGTM!

Setting rancher_import_url = "" is appropriate since enable_rancher_import = false. This correctly exercises the new validation that allows empty strings when Rancher import is disabled.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}