Fix UB from using uninitialised grasp_frame_transform #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasp_frame_transform.translation().x() and grasp_frame_transform.translation().y() are left uninitialised, while the grasp_frame_transform object is later used during planning, resulting in undefined behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made, including a reference to the related issue if applicable
I initialised
grasp_frame_transformsuch that when it is used during planning, no values ofgrasp_frame_transformare left uninitialised. This was previously the case withgrasp_frame_transform.translation().x()andgrasp_frame_transform.translation().y().Related issue: #1079
Checklist