This repository was archived by the owner on Oct 23, 2025. It is now read-only.
Present universal login announcement banner#387
Merged
Conversation
bheesham
approved these changes
May 7, 2025
Contributor
bheesham
left a comment
bheesham
left a comment
There was a problem hiding this comment.
Minor nitpicks, but looks solid. 🎉
| "iam_api_lookup": "true", | ||
| "maintenance_mode": "false" | ||
| "maintenance_mode": "false", | ||
| "header_banner_pre": "true" |
Contributor
There was a problem hiding this comment.
nitpick: JSON supports bools natively.
| module.exports = function headerBannerPre ( element ) { | ||
| var banner = document.getElementById("header-banner-pre"); | ||
| banner.style.display = "none"; | ||
| window.localStorage.setItem('header-banner-pre', 1) |
Contributor
There was a problem hiding this comment.
nitpick: mixing quote styles.
Contributor
Author
|
Excellent points in the nitpicks, but since we are about to archive this entire repo it will be a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mozilla-hub.atlassian.net/browse/IAM-1492