Refactor indexing to display as 1-indexed#26
Merged
bvisness merged 1 commit intomozilla-spidermonkey:mainfrom Dec 2, 2025
Merged
Refactor indexing to display as 1-indexed#26bvisness merged 1 commit intomozilla-spidermonkey:mainfrom
bvisness merged 1 commit intomozilla-spidermonkey:mainfrom
Conversation
Internally, the function index is 0 indexed, but displays as being 1 indexed. This patch fixes that and also limits the funcIndex to be within range of [1, numFunctions].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally, the function index is 0 indexed, but displays as being 1
indexed. This patch fixes that and also limits the funcIndex to be
within range of [1, numFunctions].
I noticed before that you could get the index to display as -1 or get
it to roll above the number of functions. This patch should fix that.