Open
Conversation
nbp
reviewed
Apr 23, 2020
Collaborator
nbp
left a comment
nbp
left a comment
There was a problem hiding this comment.
The code is ok to me, however, I do not know about the licenses.
jQuery is MIT, and jsparagus is Apache 2.0 / MIT.
Can jQuery be sub-licensed as Apache 2.0, I would not think so. so we should probably exclude the benches directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to plug jquery into jsparagus parser bench!
I had to remove
"use strict";but except of that it just works. The perf is a bit slow for criterion and it increases the time beyond its preferred 5sec to get a reliable measurement - on my machine the test takes 50s, but I think it's a useful real-life benchmark.The patch is on top of #476.