Conversation
ptomato
reviewed
Jun 18, 2021
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Is the idea for the global version() to serve as an example? or is it meant to be used in the CI? If the latter, we could just print the result of JS_GetImplementationVersion() directly.
Contributor
Author
|
It is to serve as mini example for impl native functions, because I only find them in cookbook, which is maybe too big. Running it in CI is just because someone mention that it would be good to test examples running. Should we run more examples? |
ptomato
approved these changes
Jan 28, 2022
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Seems fine to me, anyone else want to take a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two typos, adds version example which is also run in CI.