feat(cirrus): Add type hints for SDK.compute_enrollments #14361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshstrangemusic
requested review from
jaredlockhart,
jeddai and
yashikakhurana
as code owners
mikewilli
reviewed
Jan 14, 2026
Comment on lines
+16
to
+18
| class ExperimentEnrollment(TypedDict): | ||
| slug: str | ||
| status: str |
Contributor
There was a problem hiding this comment.
Should these live in the schemas package?
Member
Author
There was a problem hiding this comment.
Yeah that might be for the best going forward, but lets just sneak these in for now and file a follow-up.
relud
approved these changes
Jan 14, 2026
freshstrangemusic
force-pushed
the
push-ltsksvpxtost
branch
from
97467e9 to
7d59d91
Compare
Because: - The Cirrus API is stringly-typed; - we had a case where the types were out of sync; and - there were some misnamed variables, implying they were of a different type this commit: - adds type hints to the `SDK.compute_enrollments` method. Fixes #13717
freshstrangemusic
force-pushed
the
push-ltsksvpxtost
branch
from
7d59d91 to
8971c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
SDK.compute_enrollmentsmethod.Fixes #13717