Skip to content

fix(nimbus): fix failing intermittent test - test_get_weekly_metric_data #14376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaredlockhart wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(nimbus): fix failing intermittent test - test_get_weekly_metric_data #14376

jaredlockhart wants to merge 2 commits into from
+10 −1

Conversation

@jaredlockhart
Copy link
Collaborator

@jaredlockhart jaredlockhart commented Jan 15, 2026 •
edited by moibra05
Loading

Because

  • The test_get_weekly_metric_data was passing irregularly due to the way experiment factory randomly sets unspecified fields
  • The mentioned test relies on the primary and secondary outcomes being defined however the latter was missing and thus led to intermittent failures

This commit

  • Specifies that secondary outcomes remain empty

Fixes #14375

@jaredlockhart jaredlockhart marked this pull request as draft January 15, 2026 19:46
@moibra05 moibra05 marked this pull request as ready for review January 15, 2026 20:13
@moibra05 moibra05 removed the Blocked label Jan 15, 2026
@moibra05 moibra05 changed the title Intermittent test fixes fix(nimbus): fix failing intermittent test - test_get_weekly_metric_data Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intermittent test failure: test_get_weekly_metric_data

3 participants

@jaredlockhart @moibra05