polish(auth): Fix broken code nav in VSCODE #19964
Draft
+120
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
force-pushed
the
polish-fix-code-nav
branch
from
fbb3f49 to
2bb3b46
Compare
Contributor
|
Since I was having issues with my local setup, I grabbed the branch and poked around the modules you changed, code nav works and I haven't had any issues! I'll keep poking at it, and try switching between main and this a few more times |
Because: - We'd dynamically construct import / require paths - This would break 'goto' functionality in some IDEs This Commit: - Fixes devex by simply declaring the path in the require / import statement
dschom
force-pushed
the
polish-fix-code-nav
branch
from
2bb3b46 to
c408225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Changes largely provided by Claude...