Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Jan 29, 2026

Because

  • Email sent using the new email library were failing.

This pull request

  • Resolves an issue where the templates assets (.mjml & .txt) files were getting copied into the dist folder.
  • Provides a more developer friendly error message if the asset cannot be loaded.

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Before:
image

After:
image

Other information (Optional)

I feel like there should be a better way to do this, but... this will do for now. As mentioned in the code comment, the fxa/dist/lib/accounts/email-render/* is correct and has the extra assets. It'd be nice if all our builds were housed in the fxa/dist folder (ie mono repo root), butt that's too big of a change for a patch.

@dschom dschom requested a review from a team as a code owner January 29, 2026 00:48
@dschom dschom merged commit 5dd1e50 into main Jan 29, 2026
21 checks passed
@dschom dschom deleted the fix-missing-email-template-assets branch January 29, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants