This repository was archived by the owner on Jan 24, 2019. It is now read-only.
Requesting a pull to mozilla:master from k88hudson:nav #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
@alicoding can you review? |
bower.json
Outdated
| @@ -3,7 +3,8 @@ | |||
| "author": "@k88hudson", | |||
| "version": "0.1.8", | |||
| "dependencies": { | |||
| "bootstrap": "3.1.1" | |||
| "bootstrap": "3.1.1", | |||
| "selectize": "~0.10.1" | |||
Collaborator
There was a problem hiding this comment.
let's use a specific version here.
Collaborator
|
r+ with all the fixes. I think you might not need that function if this is only example/demo page anyway. |
k88hudson
added a commit
that referenced
this pull request
Jul 2, 2014
Requesting a pull to mozilla:master from k88hudson:nav
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all levels of the nav, the nav with icons, an example implementation, the selectize language picker