Conversation
Made some changes to the example code so it compiles. * It's necessary to call `keypair.raw_components()` and pass the `EcKeyComponents` instance to the decrypt methods. Passing in the keypair directly to the decrypt methods does not work. Updated the usage notes accordingly. * AesGcmEncryptedBlock was moved to the `legacy` module, reflected that. * Fixed parameter order on `AesGcmEncryptedBlock::new`
jrconlin
reviewed
Feb 27, 2023
| // You'll need to consult the spec for how to do this; we might add some helpers one day. | ||
| let encrypted_block = ece::AesGcmEncryptedBlock::new(dh, rs, salt, ciphertext); | ||
| let plaintext = ece::legacy::decrypt_aesgcm(keypair, auth_secret, encrypted_block)?; | ||
| let encrypted_block = ece::legacy::AesGcmEncryptedBlock::new(dh, salt, rs, ciphertext); |
Collaborator
There was a problem hiding this comment.
I know it doesn't matter for the complier, but why did you change the order of salt and rs?
Author
There was a problem hiding this comment.
That is the order of the parameters in AesGcmEncryptedBlock::new. The code doesn't compile if you use the old order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some changes to the example code so it compiles.
keypair.raw_components()and pass theEcKeyComponentsinstance to the decrypt methods. Passing in the keypair directly to the decrypt methods does not work. Updated the usage notes accordingly.legacymodule, reflected that.AesGcmEncryptedBlock::new