Moved Key extraction that was only used in tests#72
Open
DwarfsLord wants to merge 1 commit intomozilla:mainfrom
Open
Moved Key extraction that was only used in tests#72DwarfsLord wants to merge 1 commit intomozilla:mainfrom
DwarfsLord wants to merge 1 commit intomozilla:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to add an additional backend (rustls/ring), I had difficulties with the
LocalKeyPair::raw_componentsfunction.Ring does not like you to extract the private key out of a Key pair.
Considering that this function was (as far as I am aware) not part of the public API, but only used internally, I have decided to create this PR that moves it out of the trait implementation and into the OpenSSL specific impl block.
Due to the nature of scoping, and of where the tests are positioned, this also leads to an suboptimal
modstructure incrypto/mod.rs.If you know of a more idiomatic way to get the include situation sorted, feel free to let me know/edit the PR.
Thank you to all the maintainers!