This repository was archived by the owner on Jan 24, 2019. It is now read-only.
English(United States*) #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've corrected the error from “English (United State)” to “English (United States)”
app/_partials/create-user-form.html
Outdated
| @@ -24,8 +24,8 @@ <h3 class="modal-title">Welcome to Webmaker!</h3> | |||
| <div class="checkbox" ng-class="{'has-error': submit && !form.agree }"> | |||
| <label> | |||
| <input ng-model="form.agree" name="agree" type="checkbox">I agree to your | |||
| <a href="/{{lang}}/terms">terms</a>and | |||
| <a href="/{{lang}}/privacy">conditions</a> | |||
| <a href="/{{lang}}/terms">terms</a> and | |||
Contributor
There was a problem hiding this comment.
I think you might be overthinking this. It looks like all it needs is to go from
<a href="/{{lang}}/terms">terms</a>andto
<a href="/{{lang}}/terms">terms</a> and
app/_partials/create-user-form.html
Outdated
| <a href="/{{lang}}/terms">terms</a>and | ||
| <a href="/{{lang}}/privacy">conditions</a> | ||
| <a href="/{{lang}}/terms">terms</a> and | ||
| <a href="/{{lang}}/privacy"> conditions</a> |
Contributor
There was a problem hiding this comment.
there doesn't need to be a space between the anchor tag and "conditions" here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've corrected the error from “English (United State)” to “English (United States)”