Skip to content

Conversation

@Mansi-mParticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Added a custom selectplacements event that is logged when selectPlacement is called.
    The attributes passed to selectPlacement are added as custom attributes to the MPEvent, which is logged using EventType.Other.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested the feature in the sample app and added a unit test for validation.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner January 7, 2026 21:24
@rmi22186
Copy link
Collaborator

rmi22186 commented Jan 15, 2026

There may be value is separating custom attributes to show what a developer passed in vs what we add to the ultimate selectPlacements call. I am meeting with the GTM team to discuss and will follow up.

jamesnrokt
jamesnrokt previously approved these changes Jan 16, 2026
@Mansi-mParticle Mansi-mParticle force-pushed the feat/SDKE-785-log-custom-event branch from 77638ba to c9e2b00 Compare January 28, 2026 16:34
@Mansi-mParticle Mansi-mParticle force-pushed the feat/SDKE-785-log-custom-event branch from c9e2b00 to b21f0a1 Compare January 29, 2026 15:50
@Mansi-mParticle Mansi-mParticle merged commit 475ec95 into main Jan 29, 2026
16 checks passed
@Mansi-mParticle Mansi-mParticle deleted the feat/SDKE-785-log-custom-event branch January 29, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants