-
Notifications
You must be signed in to change notification settings - Fork 75
Add spinner elapsed time display and optional alert bell #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughAdds alert-bell configuration and APIs plus elapsed-time tracking and a one-shot audible bell to the console spinner; includes unit tests for elapsed formatting and bell behavior. Duplicate insertion of the alert-bell APIs is present in config.py. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
441b46f to
fb79f6d
Compare
|
The Ubuntu test failures are pre-existing issues with ✅ Quality checks pass |
This PR adds two features to the console spinner:
Features
1. Elapsed Time Display
Shows how long the spinner has been running in the format
[M:SS]or[H:MM:SS]for longer operations. This helps users understand how long they've been waiting.2. Optional Alert Bell
When enabled via config, rings the system bell after a configurable threshold (default 30 seconds) to alert users that a long-running task needs attention. The bell only rings once per spinner session.
Configuration
Changes
code_puppy/config.py: Added config keys and getter/setter functionscode_puppy/messaging/spinner/console_spinner.py: Added elapsed time display and bell alert logictests/messaging/spinner/test_console_spinner_elapsed.py: Added unit testsSummary by CodeRabbit
New Features
Tests