Conversation
giovannic
approved these changes
Nov 13, 2025
Member
giovannic
left a comment
giovannic
left a comment
There was a problem hiding this comment.
I approve. But also it feels a shame to have this juicy information buried in a function docstring and not in publicly facing documentation. If you have an idea of where it is most appropriate to add it (maybe model introduction or in the run_simulation docstring under p_inc_severe_*, I would encourage that.
… deaths from severe infection, which are not modelled here.
…(1) all infections, not only clinical, are sampled, (2) Only hospitalised severe infections are modelled, assuming 80% hospitalisation of severe cases, and (3) severe cases averted by early treatment are not captured here. (2) and (3) are addressed in the postie package.
giovannic
force-pushed
the
severe_mortality_typos
branch
from
848dc96 to
191245a
Compare
Member
|
Merging since this seems forgotten 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected and elaborated on mortality process and severe disease function descriptions.