Skip to content

Conversion notes in markdown to plan an attack #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeffscottward wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversion notes in markdown to plan an attack #3

jeffscottward wants to merge 6 commits into from

Conversation

@jeffscottward
Copy link
Contributor

@jeffscottward jeffscottward commented Sep 6, 2023

No description provided.

@jeffscottward
Copy link
Contributor Author

jeffscottward commented Sep 6, 2023

Screenshot 2023-09-06 at 5 31 52 PM

pre-existing error found after getting it running

Uncaught TypeError: THREE.PlaneBufferGeometry is not a constructor
    at initEditor ((index):261:11)
    at (index):450:7

@jeffscottward
Copy link
Contributor Author

jeffscottward commented Sep 6, 2023

fixed that error.

Ok should be working no errors again

@jeffscottward
Copy link
Contributor Author

jeffscottward commented Sep 6, 2023

@mrdoob can you merge?

@jeffscottward
Copy link
Contributor Author

jeffscottward commented Sep 12, 2023

Ping
@mrdoob

@mrdoob
Copy link
Owner

mrdoob commented Sep 14, 2023 •
edited
Loading

Rather than converting the repo, how about creating a /r3f folder and/or index-r3f.html with the r3f version for now?

I'm hoping to continue experimenting with the current code and r3f would become a blocker for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffscottward @mrdoob