Conversation
Contributor
horobito
commented
Apr 10, 2021
horobito
commented
- 타임라인 부터 pr 작성 시작
* 2) timeline 의 service 부분 구현
+ 이와 관련 내용들 수정
-> 수업자료 사용해서 적용
aerain
reviewed
Apr 10, 2021
src/main/java/com/example/demo/preperredPerson/controller/PreferredPersonController.java
Outdated
Show resolved
Hide resolved
matcher를 넣지 말자
- 해당 feed 없을 경우 테스트
- Feed 없을 경우 + CommentHelper 생성
+ 기타 코드 반환형 수정
+ 클래스들 이름 변경
1. comment 를 추가할 feed 가 없을 경우 2. feed 는 있지만, 내용이 없는 경우
3. 작성자와 친구관계가 아예 없는 경우
4. 작성자와 친구가 승인되지 않은 경우
5. 댓글 생성 테스트
aerain
approved these changes
Apr 22, 2021
|
|
||
| try { | ||
| CommentDto result = commentService.makeCommentByFeedIdAndContents(feedId, contents); | ||
| ResponseEntity.ok().body(result); |
Comment on lines
+29
to
+36
| public Long getId(){ | ||
| return this.id.getWriterId(); | ||
| } | ||
|
|
||
| public String getName(){ | ||
| return this.wrtName.getWriterName(); | ||
| } | ||
|
|
| WriterName wrtName = WriterName.create(user.getUserBasicInfo().getUsername()); | ||
| Writer writer = Writer.create(id, wrtName); | ||
| if (friendship==null || friendship.getFriendState()!= FriendShipState.ACCEPT){ | ||
| throw new IllegalAccessException(); |
| if (myId.getId().equals(feed.getId())){ | ||
| feed.delete(); | ||
| }else { | ||
| throw new IllegalAccessException(); |
| FriendShipResult result = friendShipService.deleteFriendShipRequest(friendId); | ||
| switch ((FriendShipResult)result){ | ||
| case NEVER_REQUESTED: | ||
| ResponseEntity.status(HttpStatus.BAD_REQUEST); |
Comment on lines
+59
to
+60
|
|
||
|
|
Comment on lines
+169
to
+173
| //then | ||
|
|
||
| sut.create(1L); | ||
| System.out.println("forwardFriendShip의 상태 : " + forwardFriendShip.getFriendState()); | ||
| System.out.println("backwardFriendShip의 상태 : " + backwardFriendShip.getFriendState()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.