Restructure FlightTaskAutoLine #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-add FlightTaskAutoMapper that handles the different types of waypoint and generates setpoints for all types except of position and loiter - FlightTaskAutoLine generates the setpoint types position and loiter if the flight between waypoint is a straight line - FlightTaskAutoSmooth generates setpoint types position and loiter if the flight between waypoint is a straight line plus a bezier curve in the acceptance radius
| _reset(); | ||
| bool ret = FlightTaskAutoMapper::activate(); | ||
| //_reset(); | ||
| return ret; |
There was a problem hiding this comment.
I guess we can remove the comment and just put return FlightTaskAuto::activate();
| } | ||
|
|
||
| void FlightTaskAutoLine::_generateSetpoints() | ||
| void FlightTaskAutoLine::generateSetpoints() |
There was a problem hiding this comment.
What's our convention with the '_' for member functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.