Bugfix: funny behavior after window resize due to faulty menu reset#160
Closed
recon wants to merge 1 commit intomrjasonweaver:masterfrom
recon:master
Closed
Bugfix: funny behavior after window resize due to faulty menu reset#160recon wants to merge 1 commit intomrjasonweaver:masterfrom recon:master
recon wants to merge 1 commit intomrjasonweaver:masterfrom
recon:master
Conversation
|
+1 for this change |
|
It seems the author has not had time to implement a fix and this behavior is a deal breaker for me for me.. While I am happy to download and test this myself, would like to confirm that this FIXES the issue.. Part of the reason I am asking is that I see there is another pull request (#167) which ALSO claims it addresses the issues reported in #144 & #154. Not sure if these fixes WORK, and if they do, need some understanding as to which one is the RIGHT one.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #154 (and #144).
Whenever a window resize was made while one menu item was opened, the
resetMenu()would not receive the proper context, subsequently any reset opeeration there would not be executed. Afterwards, the "toggling" would end up being inverted - hiding on mouseenter and showing on mouseleave.Also, I'm cancelling any handler on
.item-ul-libefore they are recreated, as I've noticed some funky things in Chrome which seemed to point to the fact that they are piling up with each window resize.