-
Notifications
You must be signed in to change notification settings - Fork 9
Ndarray - STYPE #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Ndarray - STYPE #56
Conversation
|
The code looks clean to me, changing no existing functionality. However, upon addition of this code, the functionality of NDArray breaks such that initialization of NDArray fills with random values when using .zeros, .ones, .array etc, it is also no longer possible to make assignments to the array correctly. It is as if the array handle is bad. You will notice there are no code changes, only additions. The closest code change is addition of a local variable mStorageType. To reproduce, checkout code and run in IRB require 'mxnet'
a = MXNet::NDArray.ones(5)
Whichever initializer I use, the result is similar. |
|
@tjad I'll work on preparing the master branch for simplifying this pull-request by picking some commits in this pull-request this weekend. After that, I want you to rebase this branch onto the latest master. |
|
@mrkn Sounds like a plan. And thanks! |
Mainly contains the STYPE work in progress . #51