feat(shutdown): implement graceful shutdown for camera session#3650
Open
EthanDM wants to merge 3 commits intomrousavy:mainfrom
Open
feat(shutdown): implement graceful shutdown for camera session#3650EthanDM wants to merge 3 commits intomrousavy:mainfrom
EthanDM wants to merge 3 commits intomrousavy:mainfrom
Conversation
- Add shutdown method to stop all outputs and release resources - Schedule shutdown with warning if it takes longer than expected
|
@EthanDM is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
5 tasks
Contributor
mrousavy
requested changes
Nov 11, 2025
Owner
mrousavy
left a comment
There was a problem hiding this comment.
Thanks for this PR - seems like there were some issues with proper session shutdown on Fabric - I wonder why that wasn't a problem before on Paper. Maybe view caching/recycling?
Anyways - I left some review comments
Co-authored-by: Marc Rousavy <me@mrousavy.com>
- Remove unnecessary delegate assignments before removing outputs - Ensure completion block is called in all error scenarios during configuration
Author
|
Thanks for the review @mrousavy, I addressed all of the comments and retested. Still no freezes during mount/unmount. Let me know if anything else is needed. |
|
Hey guys, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the navigation freeze on React Navigation/Fabric by shutting the camera session down deterministically when the view unmounts.
Changes
Tested on
Related issues