Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.util.Log
import androidx.camera.extensions.ExtensionsManager
import androidx.camera.lifecycle.ProcessCameraProvider
import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.Promise
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactContextBaseJavaModule
import com.facebook.react.bridge.ReactMethod
Expand Down Expand Up @@ -122,4 +123,36 @@ class CameraDevicesManager(private val reactContext: ReactApplicationContext) :
@Suppress("unused", "UNUSED_PARAMETER")
@ReactMethod
fun removeListeners(count: Int) {}

private suspend fun ensureInitialized() {
if (cameraProvider != null && extensionsManager != null) return

// Try init again (idempotent enough for this use-case)
if (cameraProvider == null) {
cameraProvider = ProcessCameraProvider.getInstance(reactContext).await(executor)
}
if (extensionsManager == null && cameraProvider != null) {
extensionsManager =
ExtensionsManager.getInstanceAsync(reactContext, cameraProvider!!).await(executor)
}
}

/**
* Exposed to JS: returns current available camera devices at call time.
* JS usage:
* const devices = await NativeModules.CameraDevices.getAvailableDeviceManually()
*/
@ReactMethod
fun getAvailableDeviceManually(promise: Promise) {
coroutineScope.launch {
try {
ensureInitialized()
val devices = getDevicesJson()
promise.resolve(devices)
} catch (t: Throwable) {
promise.resolve(Arguments.createArray())
}
}
}
}

27 changes: 26 additions & 1 deletion package/src/CameraDevices.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
import { NativeModules, NativeEventEmitter } from 'react-native'
import { NativeModules, NativeEventEmitter, Platform } from 'react-native'
import type { CameraDevice } from './types/CameraDevice'

const CameraDevicesManager = NativeModules.CameraDevices as {
getConstants: () => {
availableCameraDevices: CameraDevice[]
userPreferredCameraDevice: CameraDevice | undefined
}
getAvailableDeviceManually: () => Promise<CameraDevice[]>
}

const isAndroid = Platform.OS === 'android'

const constants = CameraDevicesManager.getConstants()
let devices = constants.availableCameraDevices

Expand All @@ -18,9 +21,31 @@ eventEmitter.addListener(DEVICES_CHANGED_NAME, (newDevices: CameraDevice[]) => {
devices = newDevices
})

// On Android, sometimes the devices are not ready when the module is initialized.
// So we try to fetch them again after a delay if none are available.
if (isAndroid) {
if ((devices?.length || 0) === 0) {
setTimeout(() => {
CameraDevicesManager.getAvailableDeviceManually().then((newDevices) => {
devices = newDevices
})
}, 5000)
}
}

export const CameraDevices = {
userPreferredCameraDevice: constants.userPreferredCameraDevice,
getAvailableCameraDevices: () => devices,
getAvailableCameraDevicesManually: async () => {
if (isAndroid) {
const newDevices = await CameraDevicesManager.getAvailableDeviceManually()
if ((newDevices?.length || 0) > 0) {
devices = newDevices
}
return newDevices
}
return Promise.resolve([])
},
addCameraDevicesChangedListener: (callback: (newDevices: CameraDevice[]) => void) => {
return eventEmitter.addListener(DEVICES_CHANGED_NAME, callback)
},
Expand Down
18 changes: 16 additions & 2 deletions package/src/hooks/useCameraDevices.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useState } from 'react'
import { useEffect, useRef, useState } from 'react'
import type { CameraDevice } from '../types/CameraDevice'
import { CameraDevices } from '../CameraDevices'

Expand All @@ -11,12 +11,26 @@ import { CameraDevices } from '../CameraDevices'
*/
export function useCameraDevices(): CameraDevice[] {
const [devices, setDevices] = useState(() => CameraDevices.getAvailableCameraDevices())
const numberOfDevicesRef = useRef(devices.length)

useEffect(() => {
let isMounted = true
const listener = CameraDevices.addCameraDevicesChangedListener((newDevices) => {
setDevices(newDevices)
})
return () => listener.remove()
// Only update if we got new devices and the component is still mounted
// This happens with Android only
if (numberOfDevicesRef.current === 0) {
CameraDevices.getAvailableCameraDevicesManually().then((newDevices) => {
if (isMounted && newDevices.length > 0) {
setDevices(newDevices)
}
})
}
return () => {
isMounted = false
listener.remove()
}
}, [])

return devices
Expand Down