Conversation
Summary of Changes
Overall FeedbackThis is a clean and straightforward addition! 👍 |
|
I think this repo is important enough that i set required approval to 1 for PRs. |
|
Yeah I would definitely agree. I think that should be the default for all of our open-source repos honestly |
Yeah, I would generally agree. However, it seems that required code review on brand new projects that one person is focused on fleshing out can just become a bottleneck. |
|
once mrs-sdk-qt and time-tracker are to a state that they seem "usable" or maybe "MVP", then we should require approval. time-tracker is pretty close, just needs docker container. |
Okay fair point 👍 but let's lean towards more review rather than less as long as it's not a bottleneck |
|
yeah totally. I just think code review is unnecessary in the prototyping stage. |
No description provided.