Feature/add new square challenge type #71
Merged
+158
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing gif in drawable folder.
# Conflicts: # README.md
…b.com/Zephyr-Pixilated/PlugBrain into Feature/ADD_New_Square_Challenge_type
Contributor
Author
|
I've learned alot- working with Compose and making unit tests in Android Studio. I appear to have a Lint fail from syntax error- in the SquareChallengeView.kt I messed with tabs and spaces. In the build fail, I'm getting an error on APK. I was getting the same error in that same file, I used a function to work around it to see Compose Preview that I ended up commenting out. I am looking forward to your PR Review. |
msbelaid
requested changes
Oct 6, 2025
Owner
msbelaid
left a comment
msbelaid
left a comment
There was a problem hiding this comment.
If this is your first Android contribution, that’s awesome!
I’ve left a few comments, great work again!
app/src/main/java/app/plugbrain/android/challenges/square/SquareChallengeEasyTwoThroughFive.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/challenges/square/SquareChallengeEasyTwoThroughFive.kt
Outdated
Show resolved
Hide resolved
.../main/java/app/plugbrain/android/challenges/square/SquareChallengeHardElevenThroughTwenty.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/SquareChallengeView.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/app/plugbrain/android/challenges/SquareChallengeTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/app/plugbrain/android/challenges/SquareChallengeTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/app/plugbrain/android/challenges/SquareChallengeTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/SquareChallengeView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/SquareChallengeView.kt
Outdated
Show resolved
Hide resolved
msbelaid
requested changes
Oct 6, 2025
app/src/test/java/app/plugbrain/android/challenges/SquareChallengeTest.kt
Show resolved
Hide resolved
app/src/test/java/app/plugbrain/android/challenges/SquareChallengeTest.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Okay, I believe that I fixed the issues you mentioned. Sorry, for all the commits. I've heard many commits seem to show progress. |
msbelaid
approved these changes
Oct 6, 2025
Contributor
Author
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt at a PR for adding a Square Challenge. This is an answer to issue# #63