feat: Add quit button to leave challenge screen #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioit-aaa
approved these changes
Oct 9, 2025
ioit-aaa
suggested changes
Oct 9, 2025
msbelaid
requested changes
Oct 9, 2025
Owner
msbelaid
left a comment
msbelaid
left a comment
There was a problem hiding this comment.
Awesome work! just a few comments.
app/src/main/java/app/plugbrain/android/ui/challenges/compose/NumericalInputView.kt
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/NumericalInputView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/NumericalInputView.kt
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/NumericalChallengeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/NumericalChallengeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/plugbrain/android/ui/challenges/compose/NumericalChallengeScreen.kt
Outdated
Show resolved
Hide resolved
…eature/quit-button-on-challenge-screen
2. removed exit app explanation. 3. put exit app button into bottom bar 4. use imePadding to visible button above the keyboard
ioit-aaa
approved these changes
Oct 9, 2025
Contributor
|
In general, do not merge upstream branches. Because it can be confusing for developers at times. But it looks good now. |
ioit-aaa
suggested changes
Oct 9, 2025
Contributor
ioit-aaa
left a comment
ioit-aaa
left a comment
There was a problem hiding this comment.
Very well done, just a few comments.
Contributor
|
Very good! |
Contributor
|
@msbelaid It seems that this is good |
msbelaid
approved these changes
Oct 10, 2025
ioit-aaa
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49
Screenshot: